-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code-First Federation 2 Support #3921
Open
Shane32
wants to merge
127
commits into
addfederation_extension
Choose a base branch
from
federation2
base: addfederation_extension
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Feb 26, 2024
Shane32
commented
Feb 26, 2024
Comment on lines
39
to
42
if (SourceType == typeof(object) || SourceType == typeof(Dictionary<string, object?>) || SourceType == typeof(IDictionary<string, object?>)) | ||
return representation; | ||
else | ||
return ToObject(SourceType, graphType, representation); |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Both branches of this 'if' statement return - consider using '?' to express intent better.
4 tasks
2 tasks
settings.SdlPrintOptions = new() { IncludeFederationTypes = false }; | ||
|
||
// todo: ensure all directives are supported by all supported versions | ||
var directives = settings.ImportDirectives ?? FederationDirectiveEnum.All; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
This assignment to is useless, since its value is never read.
directives
Error loading related location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3144 by @Mithras
.AddFederation()
for both schema-first, code-first and type-first use cases.Breaking changes:
__typename
field is not implicitly added to federation requestsPrerequisites:
Split into separate PRs:
To-do / nice-to-have:
[FederationResolver]
attribute to ensure it is used correctlyMoved out of scope: