Skip to content

Commit

Permalink
Merge branch 'addfederation_extension' into federation2
Browse files Browse the repository at this point in the history
  • Loading branch information
Shane32 committed Jun 20, 2024
2 parents d76d866 + bd0d28e commit ef1133d
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions docs2/site/docs/migrations/migration8.md
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,11 @@ public class Widget
}
```

### 17. Applied directives may contain metadata

`AppliedDirective` now implements `IProvideMetadata`, `IMetadataReader` and `IMetadataWriter`
to allow for reading and writing metadata to applied directives.

## Breaking Changes

### 1. Query type is required
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQL.ApiTests/net50/GraphQL.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2096,7 +2096,7 @@ namespace GraphQL.Types
public static GraphQL.Types.IObjectGraphType? GetObjectType(this GraphQL.Types.IAbstractGraphType abstractType, object value, GraphQL.Types.ISchema schema) { }
public static bool IsPossibleType(this GraphQL.Types.IAbstractGraphType abstractType, GraphQL.Types.IGraphType type) { }
}
public class AppliedDirective : System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
public class AppliedDirective : GraphQL.Utilities.MetadataProvider, System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
{
public AppliedDirective(string name) { }
public int ArgumentsCount { get; }
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQL.ApiTests/net60/GraphQL.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2096,7 +2096,7 @@ namespace GraphQL.Types
public static GraphQL.Types.IObjectGraphType? GetObjectType(this GraphQL.Types.IAbstractGraphType abstractType, object value, GraphQL.Types.ISchema schema) { }
public static bool IsPossibleType(this GraphQL.Types.IAbstractGraphType abstractType, GraphQL.Types.IGraphType type) { }
}
public class AppliedDirective : System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
public class AppliedDirective : GraphQL.Utilities.MetadataProvider, System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
{
public AppliedDirective(string name) { }
public int ArgumentsCount { get; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2034,7 +2034,7 @@ namespace GraphQL.Types
public static GraphQL.Types.IObjectGraphType? GetObjectType(this GraphQL.Types.IAbstractGraphType abstractType, object value, GraphQL.Types.ISchema schema) { }
public static bool IsPossibleType(this GraphQL.Types.IAbstractGraphType abstractType, GraphQL.Types.IGraphType type) { }
}
public class AppliedDirective : System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
public class AppliedDirective : GraphQL.Utilities.MetadataProvider, System.Collections.Generic.IEnumerable<GraphQL.Types.DirectiveArgument>, System.Collections.IEnumerable
{
public AppliedDirective(string name) { }
public int ArgumentsCount { get; }
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQL/Types/Directives/AppliedDirective.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace GraphQL.Types;
/// <summary>
/// Represents a directive applied to a schema element - type, field, argument, etc.
/// </summary>
public class AppliedDirective : IEnumerable<DirectiveArgument>
public class AppliedDirective : MetadataProvider, IEnumerable<DirectiveArgument>
{
private string _name = null!;

Expand Down

0 comments on commit ef1133d

Please sign in to comment.