Add ISchemaNodeVisitor.PostVisitSchema (#3951)

docs2/site/docs/migrations/migration8.md

@@ -385,6 +385,10 @@ for schema-first schemas where the CLR type is not defined while the resolver is
 `IsTypeOf` to be set automatically for other use cases. Schema-first schemas will automatically set this
 property to `true` for all object graph types to retain the existing behavior.
 
+### 12. `ISchemaNodeVisitor.PostVisitSchema` method added
+
+Allows to revisit the schema after all other methods (types/fields/etc) have been visited.
+
 ## Breaking Changes
 
 ### 1. Query type is required
@@ -559,3 +563,8 @@ and override only the methods you need to implement.
 
 See the new features section for details on the new properties added to these interfaces.
 Unless you directly implement these interfaces, you should not be impacted by these changes.
+
+### 14. `ISchemaNodeVisitor.PostVisitSchema` method added
+
+See the new features section for details on the new method added to this interface.
+Unless you directly implement this interface, you should not be impacted by this change.

src/GraphQL.ApiTests/net50/GraphQL.approved.txt

@@ -2833,6 +2833,7 @@ namespace GraphQL.Utilities
  public sealed class AppliedDirectivesValidationVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  public static readonly GraphQL.Utilities.AppliedDirectivesValidationVisitor Instance;
+ public void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2859,6 +2860,7 @@ namespace GraphQL.Utilities
  public abstract class BaseSchemaNodeVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  protected BaseSchemaNodeVisitor() { }
+ public virtual void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2896,6 +2898,7 @@ namespace GraphQL.Utilities
  }
  public interface ISchemaNodeVisitor
  {
+ void PostVisitSchema(GraphQL.Types.ISchema schema);
  void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema);

src/GraphQL.ApiTests/net60/GraphQL.approved.txt

@@ -2847,6 +2847,7 @@ namespace GraphQL.Utilities
  public sealed class AppliedDirectivesValidationVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  public static readonly GraphQL.Utilities.AppliedDirectivesValidationVisitor Instance;
+ public void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2873,6 +2874,7 @@ namespace GraphQL.Utilities
  public abstract class BaseSchemaNodeVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  protected BaseSchemaNodeVisitor() { }
+ public virtual void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2910,6 +2912,7 @@ namespace GraphQL.Utilities
  }
  public interface ISchemaNodeVisitor
  {
+ void PostVisitSchema(GraphQL.Types.ISchema schema);
  void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema);

src/GraphQL.ApiTests/netstandard20+netstandard21/GraphQL.approved.txt

@@ -2761,6 +2761,7 @@ namespace GraphQL.Utilities
  public sealed class AppliedDirectivesValidationVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  public static readonly GraphQL.Utilities.AppliedDirectivesValidationVisitor Instance;
+ public void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2787,6 +2788,7 @@ namespace GraphQL.Utilities
  public abstract class BaseSchemaNodeVisitor : GraphQL.Utilities.ISchemaNodeVisitor
  {
  protected BaseSchemaNodeVisitor() { }
+ public virtual void PostVisitSchema(GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema) { }
  public virtual void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema) { }
@@ -2824,6 +2826,7 @@ namespace GraphQL.Utilities
  }
  public interface ISchemaNodeVisitor
  {
+ void PostVisitSchema(GraphQL.Types.ISchema schema);
  void VisitDirective(GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitDirectiveArgumentDefinition(GraphQL.Types.QueryArgument argument, GraphQL.Types.Directive directive, GraphQL.Types.ISchema schema);
  void VisitEnum(GraphQL.Types.EnumerationGraphType type, GraphQL.Types.ISchema schema);

src/GraphQL/Extensions/SchemaExtensions.cs

@@ -341,6 +341,8 @@ public static void Run(this ISchemaNodeVisitor visitor, ISchema schema)
  break;
  }
  }
+
+ visitor.PostVisitSchema(schema);
  }
 
  /// <summary>

src/GraphQL/Utilities/Visitors/AppliedDirectivesValidationVisitor.cs

@@ -59,6 +59,9 @@ private AppliedDirectivesValidationVisitor()
  /// <inheritdoc/>
  public void VisitSchema(ISchema schema) => ValidateAppliedDirectives(schema, null, null, schema, DirectiveLocation.Schema);
 
+ /// <inheritdoc/>
+ public void PostVisitSchema(ISchema schema) { }
+
  /// <inheritdoc/>
  public void VisitUnion(UnionGraphType type, ISchema schema) => ValidateAppliedDirectives(type, null, null, schema, DirectiveLocation.Union);
 

src/GraphQL/Utilities/Visitors/BaseSchemaNodeVisitor.cs

@@ -13,6 +13,11 @@ public virtual void VisitSchema(ISchema schema)
  {
  }
 
+ /// <inheritdoc />
+ public virtual void PostVisitSchema(ISchema schema)
+ {
+ }
+
  /// <inheritdoc />
  public virtual void VisitDirective(Directive directive, ISchema schema)
  {

src/GraphQL/Utilities/Visitors/ISchemaNodeVisitor.cs

@@ -16,6 +16,11 @@ public interface ISchemaNodeVisitor
  /// </summary>
  void VisitSchema(ISchema schema);
 
+ /// <summary>
+ /// Visits <see cref="Schema"/> after all other definitions have been visited.
+ /// </summary>
+ void PostVisitSchema(ISchema schema);
+
  /// <summary>
  /// Visits registered within the schema <see cref="Directive"/>.
  /// </summary>