Junction filters #40
Open
Junction filters #40
+591
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(v4.5.0-rc.0 is now out.) |
singingwolfboy
force-pushed
the
junction-filters
branch
from
e24b2a0
to
028064c
Compare
|
This is great, thanks! I'm hesitating to merge only because filtering functionality tends to be a slippery slope (as I know all too well 😉 ). I'm also not sure it should be exposed by default.. on some of my own projects I've excluded the core PgConnectionArgCondition plugin and replaced it with the filter plugin, and I would probably exclude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements basic junction table filtering for many-to-many connections, in the same way that PgConnectionArgCondition does. By default, this filtering arg is named
junctionCondition, and is managed separately from theconditionarg. However, if the developer adds a@manyToManyCombinedConditionArgsmart comment to the constraint, the filters for the junction table and the right table will be combined in theconditionarg (and duplicated filterable columns will result in an error).This pull request depends on #43, and is rebased on top of it.