scrape: expose disabling staleness markers #34
Conversation
thampiotr
changed the title
thampiotr
force-pushed
the
thampiotr/expose-disabling-staleness-markers
branch
from
a71d93a
to
92cb90d
Compare
Signed-off-by: Piotr Gwizdala <[email protected]>
Signed-off-by: Piotr Gwizdala <[email protected]>
Signed-off-by: Piotr Gwizdala <[email protected]>
thampiotr
force-pushed
the
thampiotr/expose-disabling-staleness-markers
branch
from
92cb90d
to
53f3689
Compare
|
I can create a new branch with different name for this, but this PR is against the |
|
What is the functional change to the front end with this? Also and this might be suitable for a separate PR but there is likely some (alot) memory we can not allocate if staleness markers are disabled. |
|
My gut is that it may trigger some of the issues from this very old blog post https://promcon.io/2017-munich/slides/staleness-in-prometheus-2-0.pdf |
No changes to frontend - this is to be used by library users.
This is end-of-run staleness only, so I don't think there is much saving in Prometheus, as this is the same code path that executes when targets currently go away. Library users such as Alloy will also not just disable the staleness markers for all targets all the time. Only disable them for targets that move from one instance to another. |
Can you give a specific example? For clarity: this does not disable staleness markers permanently. It gives library users such as Alloy an option to disable them when it is needed. And in Alloy's case we only disable them when series migrates from one instance to another, so the staleness is still correctly written to TSDB at the end of the target lifecycle by its new owning instance. Let me know what issues you think this can cause. |
thampiotr
changed the base branch from
cmp_header_order
to
cmp_header_order_and_staleness_disabling
|
I'm going ahead and merge this into its own branch as grafana/alloy#703 is approved and I'd like to use this. If there's still some specific feedback, I'll be more than happy to address in a follow-up 👍 |
thampiotr
merged commit 793c8c9
into
cmp_header_order_and_staleness_disabling
Addresses the prometheus#14049 by exposing a method on scrape manager to disable staleness markers for specified targets.