Update docker-compose.yml stop exposing ports publicly #4270
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You don't want ports exposed publicly, bypassing many firewall set-ups, just by trying out this docker-compose.yml. Better only bind them to 127.0.0.1
|
|
|
Thanks for the contribution. This docker-compose file is mainly for hobby setups/testing, and in some cases it is still useful to have the ports accessible in the network. Maybe we could update the readme or docs to mention this instead? |
|
Imho especially Hobbyist should have a security by default set-up as they might be less aware of the consequences. It would be easy to add a commented out BIND_TO=0.0.0.0 into the .env, so they can easily re-enable it if they need the service on the network. Would you accept the PR, if I add this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You don't want ports exposed publicly, bypassing many firewall set-ups, just by trying out this docker-compose.yml. Better only bind them to 127.0.0.1