Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify alert grouping behaviour for demo alerts #4261

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Modify alert grouping behaviour for demo alerts #4261

wants to merge 5 commits into from
+71 −19

Conversation

ravishankar15
Copy link
Contributor

@ravishankar15 ravishankar15 commented Apr 20, 2024 •
edited by joeyorlando

What this PR does

  1. Exposes a boolean param group_alerts for the send_demo_alert endpoint
  2. Adds radio button on the frontend for toggling the grouping behaviour
Screenshot 2024-04-20 at 5 44 50 PM

Which issue(s) this PR closes

Closes #3129

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@ravishankar15 ravishankar15 force-pushed the demo-group-alerts branch 2 times, most recently from e8a42de to f9a5a77 Compare April 20, 2024 12:14
@ravishankar15 ravishankar15 marked this pull request as ready for review April 20, 2024 12:16
@ravishankar15 ravishankar15 requested review from a team as code owners April 20, 2024 12:16
@joeyorlando joeyorlando requested a review from mderynck May 14, 2024 19:58
@joeyorlando joeyorlando changed the title fix(3129) Grouping behaviour for demo alert Modify alert grouping behaviour for demo alerts May 14, 2024
@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderynck mderynck Awaiting requested review from mderynck

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override send demo alert grouping behavior
3 participants
@ravishankar15 @iskhakov @joeyorlando