Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reducing the number of Slack buttons on every alert-group post #4206

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tyrken
Copy link

@tyrken tyrken commented Apr 11, 2024

What this PR does

Currently the initial Slack post for a new Alert group contains two rows of buttons, which takes up a lot of screen real-estate besides being a bit daunting to new users. So I've added a FEATURE_FEWER_SLACK_BUTTONS to remove several buttons, chosen a bit arbitrarily by me on our expected usage:

  • Responders - we expect engineers to accept alerts via Ack rather than a manager distributes work via assigning tasks, so don't think we need this. And you can add Participants via the OnCall plugin UI.
  • Attach to - we don't expect to use this
  • Format Alert - this is only needed for initial integration setup, not long-term
  • Add Resolution notes - hide if no notes added yet (we don't expect to use this, can be done via Slack context menu if needed)
  • Unresolve - I don't think this is needed often (and can be done via OnCall plugin UI) and removing this deletes all buttons for Resolved events, which is nice both from a reduced size and the reduction in importance compared to still active alert groups.

Which issue(s) this PR closes

This doesn't fully resolve #4165 but would do most of it together with another PR I'll be opening shortly.

Checklist

I've not added any extra tests/docs yet, awaiting feedback on whether this feature is acceptable & in what form you'd like extra work before doing so.

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@tyrken tyrken requested a review from a team as a code owner April 11, 2024 11:42
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label May 12, 2024
@github-actions github-actions bot removed the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customisation of the Slack UX
3 participants