Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to mmap in store-gateway #8155

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented May 16, 2024

What this PR does

Per #4280, we removed use of mmap. This change removes references to it in architecture documentation. It also removes references to features that have been removed such as not using the bucket index.

Which issue(s) this PR fixes or relates to

Fixes #8145

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@56quarters 56quarters added the type/docs Improvements or additions to documentation label May 16, 2024
Per #4280, we removed use of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters marked this pull request as ready for review May 16, 2024 16:00
@56quarters 56quarters requested review from jdbaldry and a team as code owners May 16, 2024 16:00
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking suggestion

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters merged commit ff93a70 into main May 20, 2024
29 checks passed
@56quarters 56quarters deleted the 56quarters/sg-docs branch May 20, 2024 15:22
francoposa pushed a commit that referenced this pull request May 27, 2024
* docs: Remove references to mmap in store-gateway

Per #4280, we removed use of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>

* Code review

Signed-off-by: Nick Pillitteri <[email protected]>

---------

Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update references to mmap in store-gateway architecture
3 participants