Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update references to mmap in store-gateway architecture #8145

Closed
56quarters opened this issue May 15, 2024 · 0 comments · Fixed by #8155
Closed

Docs: Update references to mmap in store-gateway architecture #8145

56quarters opened this issue May 15, 2024 · 0 comments · Fixed by #8155
Assignees
@56quarters
Labels
component/store-gateway type/docs Improvements or additions to documentation

Comments

@56quarters
Copy link
Contributor

Is your documentation request related to a feature? If so, which one?

We removed the use of mmap from store-gateways a while ago but the architecture page still mentions it.

Describe the solution that you’d like or the expected outcome

We should remove the reference to mmap and instead describe how it works today:

https://grafana.com/blog/2023/07/17/improving-query-performance-in-grafana-mimir-why-we-dropped-mmap-from-the-store-gateway/

#4280
@56quarters 56quarters added type/docs Improvements or additions to documentation component/store-gateway labels May 15, 2024
56quarters added a commit that referenced this issue May 16, 2024
@56quarters
docs: Remove references to mmap in store-gateway
b1ba643 
Per #4280, we removed used of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters mentioned this issue May 16, 2024
Merged
4 tasks
56quarters added a commit that referenced this issue May 16, 2024
@56quarters
docs: Remove references to mmap in store-gateway
006268e 
Per #4280, we removed use of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>
@56quarters 56quarters self-assigned this May 16, 2024
56quarters added a commit that referenced this issue May 20, 2024
@56quarters
docs: Remove references to mmap in store-gateway (#8155)
ff93a70 
* docs: Remove references to mmap in store-gateway

Per #4280, we removed use of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>

* Code review

Signed-off-by: Nick Pillitteri <[email protected]>

---------

Signed-off-by: Nick Pillitteri <[email protected]>
francoposa pushed a commit that referenced this issue May 27, 2024
@56quarters @francoposa
docs: Remove references to mmap in store-gateway (#8155)
a643959 
* docs: Remove references to mmap in store-gateway

Per #4280, we removed use of mmap. This change removes references to it
in architecture documentation. It also removes references to features that
have been removed such as not using the bucket index.

Fixes #8145

Signed-off-by: Nick Pillitteri <[email protected]>

* Code review

Signed-off-by: Nick Pillitteri <[email protected]>

---------

Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@56quarters 56quarters

Labels
component/store-gateway type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Remove references to mmap in store-gateway grafana/mimir
1 participant
@56quarters