Prometheus: get Azure clouds from SDK #87676
Open
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a hard coded list
grafana-pr-automation
bot
added
datasource/Prometheus
area/frontend
pr/external
aangelisc
added
no-backport
aangelisc
changed the title
|
|
|
@academo could you please review and merge ASAP or give any additional feedback required before merge? If you agree with @aangelisc's LGTM response above, we would appreciate your sign off and merge approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The Prometheus DS frontend currently has the list of azure clouds hard coded. This PR uses the grafana-azure-sdk-react package so that the list can be updated easily. Note: in this PR I am not yet moving from the AzureCredential class defined in the Prom DS to the version of that class in the sdk - that will come in a later PR since it is lower priority.
Why do we need this feature?
This will allow Azure to easily add support for more clouds as they come online
Who is this feature for?
Azure Managed Grafana
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: