Prometheus: Fix quote stripping in parser #87675
Open
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
grafana-pr-automation
bot
added
area/frontend
pr/external
|
@ire4ever1190 Thank for the contribution! It looks ok to me but I'd like to get second opinion from @grafana/observability-metrics too. |
itsmylife
added
datasource/Prometheus
no-backport
|
Failure looks unrelated? |
|
@ire4ever1190 Yes that's unrelated and won't affect the build for now. |
|
@ire4ever1190 Could you please merge the latest |
Currently only double quotes are stripped from the end, while single quotes are left. Moreover, double quotes are stripped even when part of the value
ire4ever1190
force-pushed
the
fix/prometheus-query
branch
from
cfaa463
to
22f9328
Compare
|
Rebased with main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only double quotes are stripped from the end, while other quotes are left in. And quotes are stripped even when part of the value. This PR makes it so all quotes used in PromQL are stripped from beginning/end and also not removed from the value
Before
Extra quotes are added for instance, and the escaped quote is removed from job
After
Very minor fix but its be subtly annoying me 😅