Alerting: Encode query model map to string in rule export to avoid html escape sequences #87663
Conversation
rwwiv
requested review from
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
rwwiv
added
type/bug
area/alerting
| @@ -17,7 +17,7 @@ resource "grafana_rule_group" "rule_group_0000" { | |||
| } | |||
|
|
|||
| datasource_uid = "000000002" | |||
| model = "{\n \"expr\": \"http_request_duration_microseconds_count\",\n \"hide\": false,\n \"interval\": \"\",\n \"intervalMs\": 1000,\n \"legendFormat\": \"\",\n \"maxDataPoints\": 100,\n \"refId\": \"query\"\n }" | |||
There was a problem hiding this comment.
I wonder if it's possible to keep the result the same. Changes in export could cause diff downstream.
There was a problem hiding this comment.
Considering this also removes the noise coming from the extra whitespace and newlines, I'm of the opinion that it's not worth spending time working to keep the current output. WDYT?
That being said if we feel like consistency is more important I would have to imagine there's a way to maintain the formatting.
There was a problem hiding this comment.
It was determined this was a quirk of the test. I've pushed up a change that compacts the json to make the behavior clearer, but in any case rules previously exported like this should not contain those whitespace characters.
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs Error messagehandling pull request closed event: deleting instance by slug: unexpected response status: status=502 responseBody= <title>502 Server Error</title>Error: Server ErrorThe server encountered a temporary error and could not complete your request.Please try again in 30 seconds. |
What is this feature?
This PR fixes a bug where the alert query model could contain unicode escape sequences for certain characters in the HCL export format.
For example, math expressions could be represented as
$A \u003e 1instead of$A > 1.Why do we need this feature?
These characters cause issues when attempting to provision exported rules via Terraform.
Who is this feature for?
Users of alerting provisioning rules via Terraform.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: