Graphite: Fix alignment of elements in the query editor #87662
Merged
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWRichmond
force-pushed
the
87657/graphite-fix-query-builder-misalignment
branch
from
a7b853d
to
4b8e714
Compare
itsmylife
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
A few markup changes (adding missing divs) in the Graphite query editor.
Why do we need this change?
To fix layout issues described in #87657.
Who is this change for?
Graphite data source users.
Which issue(s) does this PR fix?
This PR fixes #87657.
Demo
Note how the elements in both of the query editor's rows are vertically aligned, in contrast with the screenshot provided in #87657.
demo.graphite.query.builder.alignment.fix.mov
Special notes for your reviewer
None
Please check that
(Not applicable)If this is a pre-GA feature, it is behind a feature toggle.