Loki: Kick start your query now applies templates to the current query #87658
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,27 @@ type Props = { | |||
| onAddQuery?: (query: LokiQuery) => void; | |||
| }; | |||
|
|
|||
| const keepOperations: string[] = [ | |||
There was a problem hiding this comment.
Could we reuse some of the logic that already exists, because whenever we add a new operation, this would be an another place that we would need to update.
I was thinking about using category from QueryBuilderOperationDefinition which defines where are shown operations:
WDYT?
There was a problem hiding this comment.
I think this is a very good idea! I'll see if we can use that.
matyax
force-pushed
the
matyax/kick-start-your-metrics
branch
from
b3633d9
to
2470a8e
Compare
matyax
force-pushed
the
matyax/kick-start-your-metrics
branch
from
3f1f790
to
dc99417
Compare
matyax
changed the title
matyax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes kick start your query to support keeping some of the pipe operations in the original query when the user chooses to replace the current query with a pattern.
To achieve that:
Work in combination with logs or metrics patterns.
Which issue(s) does this PR fix?:
Fixes #76207
Special notes for your reviewer:
Demo:
DEmo.mov