Unified Storage: Fixes bug with postgres connection string and adds tests #87656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom postgres connection string format
…age. Adds regression tests.
owensmallwood
commented
May 10, 2024
| } | ||
|
|
||
| connectionString := fmt.Sprintf( | ||
| "user='%s' password='%s' host='%s' port='%s' dbname='%s' sslmode='%s'", // sslcert='%s' sslkey='%s' sslrootcert='%s'", |
There was a problem hiding this comment.
The issue was the single quotes here. When we parse the db name from the connection string we don't expect there to be quotes around the values.
There was a problem hiding this comment.
ugh, that's nasty. It may be a good idea to update that regex to allow quotes, or use something that can parse it properly, but this workaround is fine for now imho
owensmallwood
added
no-changelog
DanCech
approved these changes
May 10, 2024
inf0rmer
approved these changes
May 13, 2024
owensmallwood
deleted the
owensmallwood/unified-storage-fix-bug-parsing-postgres-dsn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating the postgres connection string with quotes around all values. This is different than how core does it, and it was causing US to fail on startup. Refactored things a bit and added some regression tests.