Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes: Add intregation tests for scopeNodes based on example #87646

Merged
merged 3 commits into from May 13, 2024
Merged

Scopes: Add intregation tests for scopeNodes based on example #87646

merged 3 commits into from May 13, 2024

Conversation

kylebrandt
Copy link
Contributor

@kylebrandt kylebrandt commented May 10, 2024 •
edited

What is this feature?

Adding tests for ScopeNodes based on https://gist.github.com/kylebrandt/973bc9549fa1b2449b98d89c37ba0ea6

Special notes for your reviewer:
Doesn't have tests for the find endpoint, but can do that in another PR.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kylebrandt kylebrandt added no-changelog Skip including change in changelog/release notes area/scopes scopes feature labels May 10, 2024
@kylebrandt kylebrandt added this to the 11.1.x milestone May 10, 2024
@kylebrandt kylebrandt marked this pull request as ready for review May 13, 2024 14:39
@kylebrandt kylebrandt requested a review from a team as a code owner May 13, 2024 14:39
bergquist
bergquist approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@bergquist bergquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doesn't have tests for the find endpoint, but can do that in another PR.

That would be nice!

@kylebrandt kylebrandt merged commit ff6d1f4 into main May 13, 2024
14 checks passed
@kylebrandt kylebrandt deleted the scopeNodeExampleTest branch May 13, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergquist bergquist bergquist approved these changes

@toddtreece toddtreece Awaiting requested review from toddtreece

@ryantxu ryantxu Awaiting requested review from ryantxu

Assignees
No one assigned
Labels
area/backend area/scopes scopes feature no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylebrandt @bergquist