Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel query handling #1747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Parallel query handling #1747

wants to merge 2 commits into from

Conversation

iqbalaydrus
Copy link
Contributor

Solves #1746

@iqbalaydrus iqbalaydrus requested a review from a team as a code owner November 15, 2023 08:17
@iqbalaydrus iqbalaydrus requested review from zoltanbedi and gwdawson and removed request for a team November 15, 2023 08:17
@iqbalaydrus iqbalaydrus changed the title Concurrent query handling Parallel query handling Nov 15, 2023
@zoltanbedi
Copy link
Member

Hi @iqbalaydrus,
thanks for opening this PR, we are going to take a look at it soon. In the meantime can you please add tests for this?

@iqbalaydrus
Copy link
Contributor Author

I'm not quite sure what tests I should add for parallelization, do you have any suggestions?

@zoltanbedi
Copy link
Member

zoltanbedi commented Dec 5, 2023 •
edited
Loading

I'm not quite sure what tests I should add for parallelization, do you have any suggestions?

I thought you might had an idea how to properly test this. 😅

This needs some more time from us to test properly. And I'm also adding @alexanderzobnin as a reviewer.

@iqbalaydrus
Copy link
Contributor Author

Well parallization just makes things faster without changing any of the app behaviour. So as long as the current tests cover my changes it should be good. But I don't think the tests touch the QueryData method yet. I'll take a look later whether it's possible to add tests to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi zoltanbedi is a code owner automatically assigned from grafana/oss-big-tent

@gwdawson gwdawson Awaiting requested review from gwdawson gwdawson is a code owner automatically assigned from grafana/oss-big-tent

@alexanderzobnin alexanderzobnin Awaiting requested review from alexanderzobnin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
OSS Big Tent
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iqbalaydrus @zoltanbedi