Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow claims-like attribute keys #253

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wrabit
Copy link

@wrabit wrabit commented Feb 23, 2024

Motivation

The current use of dictor to dynamically fetch attribute keys using pathsep='/' interferes with commonly used url-like claim names, i.e. http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name

References:

Bumping mr @mostafa as per Contribution notes ;)

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wrabit
Copy link
Author

wrabit commented Feb 23, 2024

One potential change for discussion is using something like '->' for the pathsep instead of '|' to reduce chances someone has it in existing attribute map keys.

Copy link

github-actions bot commented Apr 9, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the no-pr-activity Stale action label Apr 9, 2024
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Apr 19, 2024
@mostafa mostafa reopened this Apr 19, 2024
@mostafa mostafa added work-in-progress Stale action and removed no-pr-activity Stale action labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants