Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashes in SAML2 attribute names don't work #167

Open
Otrebus-EL opened this issue Apr 18, 2023 · 3 comments
Open

Slashes in SAML2 attribute names don't work #167

Otrebus-EL opened this issue Apr 18, 2023 · 3 comments
Labels
work-in-progress Stale action

Comments

@Otrebus-EL
Copy link

If an attribute name contains slashes (like they often do if they follow the claim uri format like e.g. "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress") then this code fails since the slashes in the url are interpreted as dictor path separators.

@mostafa
Copy link
Member

mostafa commented Apr 28, 2023

Hey @Otrebus-EL,

the code expects the attributes to be pure and without namespaces, which is why this happens, and you already pointed it out. Do you have any idea how to solve it? If so, please make a PR and I'll review it.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the no-issue-activity Stale action label Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@mostafa mostafa added work-in-progress Stale action and removed no-issue-activity Stale action labels Apr 19, 2024
@mostafa mostafa reopened this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale action
Projects
None yet
Development

No branches or pull requests

2 participants