Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates OTEL version to v0.101.0. #906

Merged
merged 7 commits into from
May 28, 2024

Conversation

StefanKurek
Copy link
Contributor

PR Description

Updates vcenterreceiver and its many bug fixes and updates for use by Alloy. Updates probabilisticsampleprocessor to use new failed_closed config.

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@StefanKurek StefanKurek marked this pull request as ready for review May 22, 2024 17:27
CHANGELOG.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell requested a review from a team May 22, 2024 22:24
@wildum
Copy link
Contributor

wildum commented May 23, 2024

Hi, thanks for your contribution! We update our Otel dependency before every Alloy release in one go to make sure that we reflect all otel changes in our components. If you don't mind, could we merge your branch to the update-otel-v0.101.0 instead of main? I would then use your changes as a start to update the rest of the otel components

@StefanKurek
Copy link
Contributor Author

Hi, thanks for your contribution! We update our Otel dependency before every Alloy release in one go to make sure that we reflect all otel changes in our components. If you don't mind, could we merge your branch to the update-otel-v0.101.0 instead of main? I would then use your changes as a start to update the rest of the otel components

@wildum No problem. I wasn't sure if this was the case as I noticed with the recent release OTEL was still at v0.99.0 vs 0.100.0. I just wanted to get ahead of this as I'm working on the Grafana integration for vSphere, so I've first been doing the work on the OTEL receiver for vCenter. Now I'll be shifting my work to Grafana's jsonnet-libs and cloud-onboarding repos.

Also, hopefully there isn't too much else to do. I tried to look at the release notes for v0.100.0 and v0.101.0 and see what components in Alloy had updates. I "think" I hit what needed to be done in this PR? I could be wrong though...

@wildum
Copy link
Contributor

wildum commented May 23, 2024

Also, hopefully, there isn't too much else to do. I tried to look at the release notes for v0.100.0 and v0.101.0 and see what components in Alloy had updates. I "think" I hit what needed to be done in this PR? I could be wrong though...

Hey you are right actually, sorry I usually expect many more changes when we upgrade our otel dependency but I just went through the release notes and it looks like you did all the changes! That's really super helpful, I will review your code and then we will merge it to main directly

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 23, 2024
StefanKurek and others added 3 commits May 24, 2024 08:12
Updates vcenterreceiver and its many bug fixes and updates for use by Alloy.
Updates probabilisticsampleprocessor to use new failed_closed config.
Co-authored-by: Clayton Cornell <[email protected]>
@StefanKurek StefanKurek requested a review from wildum May 24, 2024 16:13
CHANGELOG.md Outdated Show resolved Hide resolved
@wildum
Copy link
Contributor

wildum commented May 24, 2024

Seems like changing the default value to true is making some tests fail. I can take a look at it on Monday

@StefanKurek
Copy link
Contributor Author

Seems like changing the default value to true is making some tests fail. I can take a look at it on Monday

@wildum digging into it a bit more, the new config field refuses data when randomness cannot be determined from the log/trace (which was the case in these test conditions). I fixed them.

@StefanKurek StefanKurek requested a review from wildum May 24, 2024 19:15
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests :) When you have time, can you update the changelog and rebase with main? I will then merge the branch

@wildum wildum merged commit eb81e62 into grafana:main May 28, 2024
15 checks passed
@wildum
Copy link
Contributor

wildum commented May 28, 2024

Merged, thanks again @StefanKurek !

@StefanKurek StefanKurek deleted the feat/update-vcenterreceiver branch May 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants