Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #29088

Closed
wants to merge 1 commit into from
Closed

Update README.md #29088

wants to merge 1 commit into from

Conversation

brandonyee-cs
Copy link

N/A Fixed Grammar

Context

Fixes grammar on the Readme N/A

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Signed-off-by: Brandon Yee <[email protected]>
@brandonyee-cs brandonyee-cs requested a review from a team as a code owner May 9, 2024 21:51
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels May 9, 2024
@gitstream-cm gitstream-cm bot added 1 min review a:documentation Documentation content labels May 9, 2024
Copy link

gitstream-cm bot commented May 9, 2024

📊 Changes by Platform: this PR is 50% new code

1 platform was affected

See details
Platform Added Lines % of Total Line Changes Deleted Lines % of Total Line Changes Files Changed % of Total Files Changed
null 3 50% 3 50% 1 100%

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHo the original variant is correct too, though the new option arguably makes it easier to read. I guess @lkasso could make the call on this

@oleg-nenashev oleg-nenashev requested a review from lkasso May 11, 2024 17:19
@lkasso
Copy link
Member

lkasso commented May 11, 2024

Thank you for your contribution. Unfortunately, this looks too much like generated English and not natural English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:documentation Documentation content from:contributor PR by an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants