Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing exports types package.json #1620

Draft
wants to merge 123 commits into
base: main
Choose a base branch
from
Draft

Conversation

PabloSzx
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

🚀 Snapshot Release (canary)

The latest changes of this PR are available as canary on npm (based on the declared changesets):

Package Version Info
@gqty/cli 4.0.0-canary-20240112214659.bf9a8a18 npm ↗︎ unpkg ↗︎
gqty 3.0.0-canary-20240112214659.bf9a8a18 npm ↗︎ unpkg ↗︎
@gqty/logger 3.0.0-canary-20240112214659.bf9a8a18 npm ↗︎ unpkg ↗︎
@gqty/react 3.0.0-canary-20240112214659.bf9a8a18 npm ↗︎ unpkg ↗︎
@gqty/subscriptions 3.0.0-canary-20240112214659.bf9a8a18 npm ↗︎ unpkg ↗︎

Copy link
Member

@vicary vicary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PabloSzx, really happy to see you around, and thanks for fixing all these tiny bits!

For the canary rollback, I think we need a tag (e.g. alpha) on NPM that is not latest, it's useful when we work on the next major with alpha tester and it's not yet ready for everyone.

kamilkisiela suggest we use the guild's template, what do you think?

@PabloSzx
Copy link
Member Author

Hey @PabloSzx, really happy to see you around, and thanks for fixing all these tiny bits!

For the canary rollback, I think we need a tag (e.g. alpha) on NPM that is not latest, it's useful when we work on the next major with alpha tester and it's not yet ready for everyone.

kamilkisiela suggest we use the guild's template, what do you think?

yeah I was happy to be using it for a test environment I was setting up and I thought gqty was the perfect candidate for it

for the versioning yeah right now since the latest version was already set to yours with scoped queries didn't want to mess it up so I merged your branch into mine, some tests are still failing but seems like snapshots that could be straight forward to fix, also using the subscriptions side of it I saw a relatively serious bug here that I fixed bf9a8a1

for the versioning I saw that the guild template worked after some small fixes we should definitely try it at least for the alphas it worked

@PabloSzx
Copy link
Member Author

I think we should try to consolidate your changes and also no need for a million different changesets this is a good rework

@vicary
Copy link
Member

vicary commented Jan 14, 2024

Please feel free to combine the changesets.

I want to merge v3 and start new features, but it's kinda stuck because of the overfetching issue described in this discord thread. It's a racing condition in React which triggers a few more request than V2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants