Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webui): make custom author roles consistent when editing book #1051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noaione
Copy link
Contributor

@noaione noaione commented Jan 19, 2023

Closes #935

Implemented to all views that dispatch dialogUpdateBooks.

New Behaviour:

  • Book/Series: Shows all the added custom author roles by default
  • Readlist/Search/Dashboard
    • Single: Shows all the added custom author roles on that series only (if it exist)
    • Multi: Check if the selected books is all from the same series, then shows all the added custom author roles on that series.

Tested on my local machine and it works as the above behavior intends.

@noaione noaione changed the title feat(webui): make custom author roles consistent feat(webui): make custom author roles consistent when bulk editing Jan 19, 2023
@noaione noaione changed the title feat(webui): make custom author roles consistent when bulk editing feat(webui): make custom author roles consistent when editing book Jan 19, 2023
@gotson gotson added the consider Not sure yet if this makes sense or not label Jun 10, 2023
@noaione noaione force-pushed the feat/consistent-custom-author-roles branch from d8f5c2d to 7ad106e Compare October 13, 2023 14:37
@noaione noaione force-pushed the feat/consistent-custom-author-roles branch from 2452f36 to 55bbd0f Compare October 28, 2023 10:53
@noaione noaione force-pushed the feat/consistent-custom-author-roles branch from 55bbd0f to 8ddec39 Compare November 12, 2023 03:51
@noaione noaione force-pushed the feat/consistent-custom-author-roles branch from 8ddec39 to aaa0116 Compare November 28, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consider Not sure yet if this makes sense or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make custom author fields in bulk editing consistent if the series have it
2 participants