fix: markdown load slow #307
Conversation
LiusCraft
force-pushed
the
fix/article-view
branch
from
6f15bcf
to
0b3dd04
Compare
|
/assign @nighca |
cmd/gopcomm/yap/article_yap.html
Outdated
| @@ -642,7 +641,9 @@ <h1 class="my-4 text-3xl font-extrabold leading-tight text-gray-900"> | |||
| var htmlStr = document.documentElement.outerHTML; | |||
|
|
|||
| // get article toc | |||
| getArticleToc(); | |||
| // markdown load slow, so we need to timeout get toc | |||
| setTimeout(getArticleToc,200) | |||
There was a problem hiding this comment.
有没有可能通过 MarkdownViewer 暴露的事件感知 markdown load 完成的？
cmd/gopcomm/yap/layout_yap.html
Outdated
| @@ -23,7 +23,7 @@ | |||
| <link href="https://fonts.cdnfonts.com/css/inter" rel="stylesheet" /> | |||
| <link rel="preconnect" href="https://fonts.proxy.ustclug.org" /> | |||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | |||
| <link href="https://fonts.proxy.ustclug.org/css2?family=Noto+Sans+SC&display=swap" rel="stylesheet" /> | |||
| <!-- <link href="https://fonts.proxy.ustclug.org/css2?family=Noto+Sans+SC&display=swap" rel="stylesheet" /> --> | |||
LiusCraft
force-pushed
the
fix/article-view
branch
2 times, most recently
from
498ce6a
to
c12677d
Compare
| @@ -631,17 +632,16 @@ <h1 class="my-4 text-3xl font-extrabold leading-tight text-gray-900"> | |||
| MarkdownViewer: window.GoplusMarkdown.MarkdownViewer | |||
| }, | |||
| mounted() { | |||
| // set markdown change callback function | |||
| // look cmd/gopcomm/yap/markdown-vue/src/components/MarkdownViewer.vue | |||
| window.mdChange=getArticleToc | |||
There was a problem hiding this comment.
通过 window.xxx 作为事件 handler 不是常规的做法，也有明显的问题
这里 MarkdownViewer 是个 vue component，可以通过 vue component 的事件来做，比如把 getArticleToc 添加到上边 methods 里，然后在模板中绑定事件：
<markdown-viewer :md="article.Content" style="height: auto;" @change="getArticleToc"></markdown-viewer>对应地在 MarkdownViewer 中去 emit change 事件即可；
详见 https://vuejs.org/guide/components/events.html#component-events
There was a problem hiding this comment.
那先保留 window.mdChange 的做法，然后在这里注释记个 TODO 吧
LiusCraft
force-pushed
the
fix/article-view
branch
from
c12677d
to
b8f8564
Compare
|
|
||
| var cherrInstance = null | ||
|
|
||
| // this is markdown change callback | ||
| // TODO: In order to change the callback function by article_yap.html, this is the worst way to do this. |
There was a problem hiding this comment.
Nit: TODO 中说明下要“do”什么会更好。这边只说了问题，没说要做什么
LiusCraft
force-pushed
the
fix/article-view
branch
from
b8f8564
to
b0af2f0
Compare
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after 6 hours, please make sure to test it in time. If you have any questions, please contact the author of the PR or the community team. |
No description provided.