deploye: add release build config #267
Conversation
![qiniu-x[bot]](https://avatars.githubusercontent.com/in/752628?s=60&v=4){kind=small}
internal/core/community.go
Outdated
| configFile := "" | ||
| flag.StringVar(&configFile, "config", "", "Path to the config file") | ||
| flag.Parse() | ||
| godotenv.Load(configFile) |
There was a problem hiding this comment.
[golangci-lint] Error return value of godotenv.Load is not checked (errcheck)
If you have any questions about this comment, feel free to raise an issue here:
docs/sql/database-init.sql
Outdated
There was a problem hiding this comment.
It's better to dump sql from mysql.
internal/core/community.go
Outdated
| func init() { | ||
| configFile := "" | ||
| flag.StringVar(&configFile, "config", "", "Path to the config file") | ||
| flag.Parse() | ||
| godotenv.Load(configFile) |
There was a problem hiding this comment.
We don't need it, autoload will autoload .env in same dir.
|
@LiusCraft: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
LiusCraft
changed the title
cmd/gopcomm/gop_autogen.go
Outdated
| community *core.Community | ||
| trans *translation.Engine | ||
| } | ||
| //line cmd/gopcomm/community_yap.gox:30 |
There was a problem hiding this comment.
[gofmt] Is your code not properly formatted? Here are some suggestions below
| //line cmd/gopcomm/community_yap.gox:30 |
If you have any questions about this comment, feel free to raise an issue here:
internal/core/community.go
Outdated
| @@ -160,6 +165,14 @@ type Translation struct { | |||
| VideoTaskCache *VideoTaskCache | |||
| } | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
We parse config from gox entry file.
|
@LiusCraft: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after 6 hours, please make sure to test it in time. If you have any questions, please contact the author of the PR or the community team. |
No description provided.