Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlacesClient.awaitFindCurrentPlace has an incorrect set of permissions in the @RequiresPermission annotation #230

Closed
dkhawk opened this issue Feb 6, 2024 · 1 comment · Fixed by #231
Closed

PlacesClient.awaitFindCurrentPlace has an incorrect set of permissions in the @RequiresPermission annotation #230

dkhawk opened this issue Feb 6, 2024 · 1 comment · Fixed by #231
Assignees
@dkhawk
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dkhawk
Copy link
Contributor

dkhawk commented Feb 6, 2024

PlacesClient.awaitFindCurrentPlace has an incorrect set of permissions in the @RequiresPermission annotation

The correct set are anyOf = [ permission.ACCESS_FINE_LOCATION, permission.ACCESS_COARSE_LOCATION ]
@dkhawk dkhawk added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Feb 6, 2024
@dkhawk dkhawk self-assigned this Feb 6, 2024
@dkhawk dkhawk removed the triage me I really want to be triaged. label Feb 6, 2024
@wangela
Copy link
Member

wangela commented Feb 6, 2024

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@dkhawk Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@dkhawk dkhawk linked a pull request Feb 6, 2024 that will close this issue
fix: sets the correct permissions on PlacesClient.awaitFindCurrentPlace @RequiresPermission annotation #231
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkhawk dkhawk

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@dkhawk @wangela