Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featuregate: adds validation if PortPolicyNone is not enabled #3871

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

daniellee
Copy link
Contributor

When the feature gate PortPolicyNone is used, validation should fail if the PortPolicy field is set to the value None.

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Without this validation, then the Container Port is set to 0 and it silently fails.

Which issue(s) this PR fixes:
Closes #3867

Special notes for your reviewer:

Then validation should fail if the PortPolicy field is set to the value None
@github-actions github-actions bot added kind/bug These are bugs. size/S labels Jun 14, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c976d4fc-f218-467c-8b07-42c77f6d5d0d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3871/head:pr_3871 && git checkout pr_3871
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-9c9ccac-amd64

@daniellee daniellee marked this pull request as ready for review June 14, 2024 19:03
@zmerlynn zmerlynn assigned zmerlynn and igooch and unassigned zmerlynn Jun 17, 2024
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch enabled auto-merge (squash) June 17, 2024 21:00
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 519b0e81-0522-48b0-82d4-20d0fb511646

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3871/head:pr_3871 && git checkout pr_3871
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-26d392a-amd64

@igooch igooch merged commit 541dafe into googleforgames:main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using portPolicy None results in a gameserver's port being 0
4 participants