Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local SDK: Refactor List and Count keys for default GameServer #3598

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3597

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Jan 17, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a6911f8c-1940-4014-b993-b36a64f43292

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Kalaiselvi84 Kalaiselvi84 marked this pull request as draft January 18, 2024 00:16
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cb711746-9c72-4d8d-b165-44bbb97b7cb7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3598/head:pr_3598 && git checkout pr_3598
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-60854e5-amd64

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review January 18, 2024 22:22
@Kalaiselvi84
Copy link
Contributor Author

Is there anything pending/blocking us to merge this PR?

@igooch igooch merged commit eb4035e into googleforgames:main Jan 22, 2024
4 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the pr-3597 branch March 15, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local SDK: Refactor List and Count keys for default GameServer
3 participants