Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Label PR Warning #3241

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

aimuz
Copy link
Collaborator

@aimuz aimuz commented Jun 29, 2023

Signed-off-by: aimuz [email protected]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Warning: Unexpected input(s) 'repo-token', valid inputs are ['script', 'github-token', 'debug', 'user-agent', 'previews', 'result-encoding']

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 190e7654-78bb-4b48-9935-3379962ebe6f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3241/head:pr_3241 && git checkout pr_3241
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.33.0-dev-ad6d3ee-amd64

@markmandel
Copy link
Member

@Kalaiselvi84 you are the expert on this one - this look good to you?

@Kalaiselvi84
Copy link
Contributor

Kalaiselvi84 commented Jul 6, 2023

@Kalaiselvi84 you are the expert on this one - this look good to you?

I have tested it in my fork without including repo-token: ${{ secrets.GITHUB_TOKEN }}, and it is working fine. According to the documentation at https://docs.github.com/en/actions/security-guides/automatic-token-authentication, the secrets.GITHUB_TOKEN is automatically available to all workflows running in the repository, and there is no need to explicitly define or store it in the repository's secrets. However, it is important to consider the security implications, by not using this token could potentially grant unauthorized access to the repository. Nevertheless, since it is an open-source project, it should be acceptable to omit its usage. WDYT?

@aimuz
Copy link
Collaborator Author

aimuz commented Jul 6, 2023

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d12da036-dec4-4dc4-8498-8b253d1db60f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3241/head:pr_3241 && git checkout pr_3241
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-956dc2b-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this is a valid fix then.

@google-oss-prow google-oss-prow bot added the lgtm label Jul 6, 2023
@markmandel markmandel merged commit a641b32 into googleforgames:main Jul 6, 2023
2 checks passed
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc and removed kind/other labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants