Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py.typed metadata to MANIFEST.in #213

Closed
wants to merge 1 commit into from

Conversation

jamesbraza
Copy link

@jamesbraza jamesbraza requested a review from a team as a code owner May 22, 2024 05:38
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 22, 2024
@asottile-sentry
Copy link

this is not the right way to do this -- here's the correct way to include it in the package data: #211

@jamesbraza
Copy link
Author

I sort of feel like Python packaging dropped the ball with py.typed a bit. It's a really common hiccup. Will close this PR in favor of yours, thanks

@jamesbraza jamesbraza closed this Jun 14, 2024
@jamesbraza jamesbraza deleted the adding-py-typed branch June 14, 2024 22:51
@asottile-sentry
Copy link

agreed -- you may want to update googleapis/google-auth-library-python#1526 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants