Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: destroy sockets to stop memory leaking when stream errors #2336

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: destroy sockets to stop memory leaking when stream errors #2336

merged 1 commit into from
Oct 19, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2313 馃

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners October 19, 2023 14:37
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 19, 2023
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: xs Pull request size is extra small. labels Oct 19, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 19, 2023
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2023
@ddelgrosso1 ddelgrosso1 merged commit 04939ee into googleapis:main Oct 19, 2023
16 checks passed
@ddelgrosso1 ddelgrosso1 deleted the abort-agent branch October 19, 2023 16:10
@release-please release-please bot mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when stream is not read to the end.
3 participants
@ddelgrosso1 @danielbankhead @yoshi-kokoro