Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve issue templates and directions for filing in correct repo #12710

Merged
merged 15 commits into from
Jun 6, 2024

Conversation

vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented May 17, 2024

Fixes #12651

TAL @ the main branch on my fork to preview the experience.

TODODONE: When this has been approved, and prior to merging, I'll update all links to refer to the main (upstream) repo and not my fork.

@vchudnov-g vchudnov-g requested a review from a team as a code owner May 17, 2024 22:49
@vchudnov-g vchudnov-g marked this pull request as draft May 17, 2024 22:49
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 observation. I'll re-review once this is ready

SUPPORT.md Outdated

1. Consider using [Google Cloud Customer Care](https://cloud.google.com/support/?hl=en) (paid) to get more dedicated support for your issue. Otherwise, continue with the steps below.
2. Find your API in [the client list at the top of this repository](https://github.com/googleapis/google-cloud-python/tree/main?tab=readme-ov-file#libraries).
3. Check the “Issue Tracker” column to see whether someone else has reported the same issue. If they have, the filed issue may have some useful information; feel free to add more details or context of your own.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note that folks can file API issues in the corresponding client library repository in the case where there is no API specific issue tracker?

@vchudnov-g vchudnov-g force-pushed the issue-templates branch 6 times, most recently from d2b4192 to 0d8076f Compare June 1, 2024 00:24
@vchudnov-g vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 1, 2024
@vchudnov-g
Copy link
Contributor Author

Adding do not merge until this has been approved and I then change the links to point to the main repo and not my fork. In the meantime, reviewers can experience the new templates by going to my fork.

@vchudnov-g vchudnov-g marked this pull request as ready for review June 1, 2024 00:28
@vchudnov-g vchudnov-g requested a review from ohmayr June 1, 2024 00:28
@vchudnov-g vchudnov-g assigned parthea and unassigned vchudnov-g Jun 1, 2024
- type: input
attributes:
label: API client name and version
description: Try `pip list | grep google-cloud`, which should give you a name corresponding to one of the packages listed [here](https://github.com/googleapis/google-cloud-python/tree/main/packages).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Try `pip list | grep google-cloud`, which should give you a name corresponding to one of the packages listed [here](https://github.com/googleapis/google-cloud-python/tree/main/packages).
description: Try `pip list | grep google`, which should give you a name corresponding to one of the packages listed [here](https://github.com/googleapis/google-cloud-python/tree/main/packages).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Did it with a trailing hyphen. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be helpful without the trailing hyphen as an additional package googleapis-common-protos will be included

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good catch! Will do.

.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
SUPPORT.md Outdated
# Check for already opened issues:

- In `google-cloud-python`: <https://github.com/googleapis/google-cloud-python/issues>
- In Stack Overflow: <https://stackoverflow.com/questions/tagged/google-cloud-platform+python>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to list Stack Overflow here? Does it belong in the bug intake process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was basing this off of what NodeJS is doing: https://github.com/googleapis/google-cloud-node/issues/new?assignees=&labels=bug&projects=&template=bug_report.yml

We can take it out, though I think there could be value in pointing people to "easy" places to search for issues. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that users won't report issue in Github if they're already in Stack Overflow. As an example, see #12749 (comment) which mentions that an issue was reported on Stack Overflow a month ago and only reported in this repository in the last week. If Stack Overflow is not part of our bug intake, then we shouldn't mention it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see your point. The purpose was to help users help themselves more quickly, but you're right, it does run the risk that even if the community finds a workaround, we won't hear about it to incorporate it or fix the code because no formal issues are filed. OK, I'll take it out, though I do think some reference to searching on SO might be good. But we have to determine the right phrasing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the python-api-common-protos bug template, they say this: maybe we should incorporate it? WDYT, @parthea ?

Please run down the following list and make sure you've tried the usual "quick fixes":

  - Search the issues already opened: https://github.com/googleapis/python-api-common-protos/issues
  - Search StackOverflow: https://stackoverflow.com/questions/tagged/google-cloud-platform+python

If you are still having issues, please be sure to include as much information as possible:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording sounds good to me. We should encourage users to open issues for bugs, even if there are workarounds/quick fixes. It would be good to incorporate that as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm submitting without the SO reference, and we can wordsmith that in via a chaser PR.

@parthea parthea assigned vchudnov-g and unassigned parthea Jun 3, 2024
@vchudnov-g vchudnov-g removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 6, 2024
@vchudnov-g vchudnov-g enabled auto-merge (squash) June 6, 2024 21:48
@vchudnov-g vchudnov-g added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2024
@vchudnov-g vchudnov-g merged commit 8a65999 into googleapis:main Jun 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub issue templates: clarify; provide easy access to back-end support channels
2 participants