feat!: [Spanner] Upgrade to V2 #7193
Conversation
ajupazhamayil
force-pushed
the
spanner-v2
branch
2 times, most recently
from
843be5e
to
55a81e9
Compare
ajupazhamayil
force-pushed
the
spanner-v2
branch
from
55a81e9
to
37076aa
Compare
We did not create any design document for these changes. We are following a V2 parent doc drafted by @saranshdhingra. Basically we are trying to remove usage of Please let me know if you would like me to create a doc for this purpose. |
ajupazhamayil
changed the title
ajupazhamayil
changed the title
bshaffer
changed the title
ajupazhamayil
changed the title
Spanner: upgrade to V2 (Part 2/2)
| @@ -184,6 +184,9 @@ public function getOperationsClient() | |||
| public function resumeOperation($operationName, $methodName = null) | |||
| { | |||
| $options = isset($this->descriptors[$methodName]['longRunning']) ? $this->descriptors[$methodName]['longRunning'] : []; | |||
| // OperationResponse is a V1 surface class, we need V2 surface class. | |||
| // [V2 LongRunning/Client/OperationsClient, getOperation] | |||
| // Other clients have also used the OperationResponse similarly. | |||
| $operation = new OperationResponse($operationName, $this->getOperationsClient(), $options); | |||
There was a problem hiding this comment.
These changes can be removed once the migration mode is fixed.
There was a problem hiding this comment.
We should modify the MIGRATION_MODE locally and generate the client as part of this PR, so we can preview those changes. Then we can merge the CL to change the migration mode once this PR is merged
There was a problem hiding this comment.
Discussed internally that Brent will take care of the MIGRATION_MODE, Thanks!
ajupazhamayil
changed the title
|
The "Prefer Lowest" tests are failing because you've added a new |
Great, the test is passing now.. |
Spanner V2:
Part 1:
RequestHandler[Operationclass]RequestHandler[Databaseclass]RequestHandler[Sessionclass]RequestHandler[CacheSessionPoolclass]RequestHandlerin Core'sLongRunningOperation]Part 2:
RequestHandler[Backupclass]RequestHandler[Instanceclass]RequestHandler[InstanceConfigurationclass]RequestHandler[SpannerClient]Tests:
Related work:
OperationsClient[GAPIC generator change] [See @todo in Spanner/src/Admin/Database/V1/Client/DatabaseAdminClient.php] : This is replaced with the migration status changes.BREAKING_CHANGE_REASON=RC-1 for the version 2 of the Spanner library.