[pointer] Add Ptr::into_transparent_wrapper #1199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - Audit uses of associated types for consistency regarding Wrap vs Unwrap: make sure we're always using the correct direction - Audit bidirectional variance types (UnsafeCellVariance, ValidityVariance) and make sure that safety comments justify both directions - File issue to track making TransparentWrapper smart enough to distinguish between shared pointer conversions and exclusive pointer conversions
joshlf
force-pushed
the
transparent-wrapper-into-wrapper
branch
from
e0418b6
to
4c1b781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: