Relax NoCell bound of TryFromBytes::try_from_mut
#1017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
relax-try_cast_into
branch
from
c20a0ef
to
c8d6674
Compare
jswrenn
force-pushed
the
relax-cast_unsized
branch
from
dac2194
to
5c9afdf
Compare
jswrenn
force-pushed
the
relax-try_cast_into
branch
from
c8d6674
to
f848f26
Compare
joshlf
requested changes
Mar 5, 2024
src/pointer/ptr.rs
Outdated
| /// | ||
| /// `Ptr` requires that: | ||
| /// | ||
| /// > During the lifetime 'a, no live reference or live `Ptr` will exist to this |
There was a problem hiding this comment.
Suggested change
| /// > During the lifetime 'a, no live reference or live `Ptr` will exist to this | |
| /// > During the lifetime `'a`, no live reference or live `Ptr` will exist to this |
There was a problem hiding this comment.
Done (this particular doc comment no longer exists).
src/pointer/ptr.rs
Outdated
| /// > memory which treats `UnsafeCell`s as existing at different ranges than | ||
| /// > they exist in `T`. | ||
| /// | ||
| /// Implementations of this trait must prove that for an aliasing `A`, a cast of |
There was a problem hiding this comment.
Suggested change
| /// Implementations of this trait must prove that for an aliasing `A`, a cast of | |
| /// Implementations of this trait must prove that, for an aliasing `A`, a cast of |
There was a problem hiding this comment.
Done (this particular doc comment no longer exists).
src/pointer/ptr.rs
Outdated
| /// | ||
| /// Implementations of this trait must prove that for an aliasing `A`, a cast of | ||
| /// `Ptr<T, Aliasing = A>` to `Ptr<U, Aliasing = A>` does not introduce a live | ||
| /// reference to `U` with `UnsafeCell`s at different ranges than a live |
There was a problem hiding this comment.
Suggested change
| /// reference to `U` with `UnsafeCell`s at different ranges than a live | |
| /// reference or `Ptr` to `U` with `UnsafeCell`s at different ranges than a live |
There was a problem hiding this comment.
Done (this particular doc comment no longer exists).
src/pointer/ptr.rs
Outdated
| /// Implementations of this trait must prove that for an aliasing `A`, a cast of | ||
| /// `Ptr<T, Aliasing = A>` to `Ptr<U, Aliasing = A>` does not introduce a live | ||
| /// reference to `U` with `UnsafeCell`s at different ranges than a live | ||
| /// reference to `T`. |
There was a problem hiding this comment.
Suggested change
| /// reference to `T`. | |
| /// reference or `Ptr` to `T`. |
There was a problem hiding this comment.
Done (this particular doc comment no longer exists).
src/pointer/ptr.rs
Outdated
Comment on lines
1119
to
1124
| pub(crate) fn try_cast_into<U: 'a + ?Sized + KnownLayout>( | ||
| &self, | ||
| cast_type: CastType, | ||
| ) -> Option<(Ptr<'a, U, (I::Aliasing, invariant::Aligned, invariant::Initialized)>, usize)> | ||
| where | ||
| [u8]: NoCellSafe<U, I::Aliasing>, |
There was a problem hiding this comment.
Presumably the changed bounds mean we also need to update the internal safety comments in this method body?
jswrenn
force-pushed
the
relax-try_cast_into
branch
from
f848f26
to
46674af
Compare
Makes progress towards #5. Closes #1014. Co-authored-by: Joshua Liebow-Feeser <[email protected]>
jswrenn
force-pushed
the
relax-try_cast_into
branch
from
46674af
to
1421250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress towards #5.
Closes #1014.