Remove NoCell
bounds emitted by derive(TryFromBytes)
on unions
#1016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the approach used to implement
is_bit_valid
forUnsafeCell
to unions. However, it's not entirely satisfactory in this case. Yes, it enables us to remove theNoCell
field bounds fromderive(TryFromBytes)
on unions. Unfortunately, it also makesis_bit_valid
uncallable byTryFromBytes::try_from_ref
, even whenSelf: NoCell
.Maybe we can apply an approach similar to the one used to solve #1014 to handle this.
Makes progress towards #5.
Closes #1015.