Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added XMLLint capability for XML #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rupert160
Copy link

Second attempt to push XML rebased to ensure no original email

@fowles
Copy link
Member

fowles commented Mar 25, 2018

A basic test like https://github.com/google/vim-codefmt/blob/master/vroom/dartfmt.vroom would be very much appreciated

Copy link
Contributor

@dbarnett dbarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the lists in the README and in autoload/codefmt.vim / generated help file?

Re tests, the quickfix logic is involved enough it should have at least one quick bit of vroom coverage, but if you wanted to pull that out for now and just let it print an error message, I'd be fine with adding the test file myself as a follow-up change so it's more convenient for you to get something merged.

let l:formatter = {
\ 'name': 'xmllint',
\ 'setup_instructions': 'Install xmllint. ' .
\ '(man xmllint).'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"man xmllint" isn't too helpful as installation instructions. It'd only do anything if xmllint were already installed. Could you point to a website with info about how to install on various platforms?

Copy link

@vishnuraj-r vishnuraj-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Redacted and reported. Looks like phishing attempt.)

@TruncatedDinoSour
Copy link

a``

I agree

TruncatedDinoSour pushed a commit to TruncatedDinoSour/vim-codefmt that referenced this pull request Jan 15, 2022
Signed-off-by: Ari Archer <[email protected]>
TruncatedDinoSour pushed a commit to TruncatedDinoSour/vim-codefmt that referenced this pull request Jan 15, 2022
Signed-off-by: Ari Archer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants