removed the integer and bits scaling in quantized bits for alpha=auto and alpha=auto_po2 #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the quantized_bits class, when alpha=auto or alpha=auto_po2, the unquantized value "x" is manipulated in a strange way. Even if the number of integer bits is not considered when scaling with alpha=auto and alpha=auto_po2, "x" is divided by m_i (, namely 2**integer_bits) to be later remultiplied by the same value m_i. As x is originally divided by m_i, z (which depends on x) is later multiplied by m_i and divided by m. In order to adjust for the division by m, the scale factor (which multiplies z) is multiplied by m.
I removed the m_i and m references in the code as they don't matter when considering alpha=auto or alpha=auto_po2. I also tested this new version of the quantizer with older versions and the result is the same.