Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar.ts DOM text reinterpreted as HTML #4756

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Shivam7-1
Copy link
Contributor

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

And Also Added HTMLElement to Recognise innertext Element in it

@Shivam7-1
Copy link
Contributor Author

Hi @elalish Could You Please Review This PR
Regards

@elalish
Copy link
Collaborator

elalish commented Apr 18, 2024

I'll review it once you get the tests to pass. I'll be happy to answer questions if you have any.

@Shivam7-1
Copy link
Contributor Author

Hi @elalish Thanks For Reply
I think it won't cause any test Failure
Could you Check is there anything else Required
Regards

@elalish
Copy link
Collaborator

elalish commented Apr 18, 2024

I think it won't cause any test Failure

It is literally causing a build failure - it can't even get as far as running the tests. Do you see the Red X below? Please click on the details, understand the problem, then fix it.

@Shivam7-1
Copy link
Contributor Author

Hi @elalish Thanks For Reviewing
I also Tried to Overcome From Unit Test Failure But It's always Faliling I had also try using
textcontent instead of innertext
But then also it's failing test case over here

Could You please Check over here is there any problem with config.json file ?

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants