Expunge fidelity (#4779)

* update URL, kill deployment

* remove goldens

* remove renderers

* make render-goldens faster

* update readmes

packages/model-viewer/README.md

@@ -15,7 +15,7 @@ As new standards and APIs become available `<model-viewer>` will be improved
 to take advantage of them. If possible, fallbacks and polyfills will be
 supported to provide a seamless development experience.
 
-[Demo](https://model-viewer.glitch.me) • [Documentation](https://modelviewer.dev/) • [Quality Tests](https://modelviewer.dev/fidelity/)
+[Demo](https://model-viewer.glitch.me) • [Documentation](https://modelviewer.dev/) • [Quality Comparisons](https://github.khronos.org/glTF-Render-Fidelity/comparison/) (courtesy of Khronos)
 
 
 ## Installing

packages/modelviewer.dev/data/faq.json

@@ -62,9 +62,9 @@
  {
  "name": "How high is our rendering quality?",
  "htmlName": "quality",
- "description": "<model-viewer> uses three.js for rendering, which is high-quality and rapidly supports the most recent PBR glTF extensions. The advantage of glTF is that it is widely-supported with consistent rendering (assuming the render parameters are set up the same way). We track convergence of the most popular glTF renderers to demonstrate the state of the industry and to file bugs to drive further improvement; see for yourself at the following link.",
+ "description": "<model-viewer> uses three.js for rendering, which is high-quality and rapidly supports the most recent PBR glTF extensions. The advantage of glTF is that it is widely-supported with consistent rendering (assuming the render parameters are set up the same way). We track convergence of the most popular glTF renderers to demonstrate the state of the industry and to file bugs to drive further improvement; see for yourself at the following Khronos link.",
  "links": [
- "<a href='../fidelity'>glTF fidelity comparison</a>"
+ "<a href='https://github.khronos.org/glTF-Render-Fidelity/comparison/'>Khronos glTF fidelity comparison</a>"
  ]
  },
  {

packages/modelviewer.dev/examples/color.html

@@ -183,9 +183,10 @@ <h2>Achieving Color-Accurate Presentation with glTF</h2>
  a consistent photo, you need to not just have the same object, but also the
  same lighting and camera settings. There is no standard for the default
  settings of these viewers, so it is important to intentionally set them to
- consistent values. This is precisely what we've done to show the state of <a
- href="../fidelity">glTF rendering convergence</a> across a variety of
- popular renderers.</p>
+ consistent values. This is precisely what we and Khronos have done to show
+ the state of <a
+ href="https://github.khronos.org/glTF-Render-Fidelity/comparison/">glTF
+ rendering convergence</a> across a variety of popular renderers.</p>
 
  <h3 id="accuracy">What is color accuracy?</h3>
 

packages/modelviewer.dev/scripts/ci-before-deploy.sh

@@ -97,7 +97,6 @@ done
 set -x
 
 # Copy the latest fidelity testing results:
-mkdir -p $DEPLOY_ROOT/fidelity
 mkdir -p $DEPLOY_ROOT/editor
 mkdir -p $DEPLOY_ROOT/editor/view
 mkdir -p $DEPLOY_ROOT/dist
@@ -110,9 +109,6 @@ mkdir -p $DEPLOY_ROOT/node_modules/@google/model-viewer-effects/dist
 mkdir -p $DEPLOY_ROOT/node_modules/js-beautify
 mkdir -p $DEPLOY_ROOT/node_modules/web-animations-js
 
-mv ../render-fidelity-tools/test/results $DEPLOY_ROOT/fidelity/results
-cp ../render-fidelity-tools/test/results-viewer.html $DEPLOY_ROOT/fidelity/index.html
-cp ../render-fidelity-tools/dist/* $DEPLOY_ROOT/dist/
 cp ../space-opera/editor/index.html $DEPLOY_ROOT/editor/
 cp ../space-opera/editor/view/index.html $DEPLOY_ROOT/editor/view/
 cp ../space-opera/dist/space-opera.js $DEPLOY_ROOT/dist/

packages/render-fidelity-tools/README.md

@@ -1,8 +1,7 @@
 # Render fidelity tools
 
 This package contains tools and testing processes that enable the
-`<model-viewer>` project to ensure high-fidelity 3D model rendering as well
-as compare its rendering qualities to those of other renderers.
+`<model-viewer>` project to ensure high-fidelity 3D model rendering.
 
 If you are looking for the `<model-viewer>` web component, please refer to the
 [`<model-viewer>` package](../model-viewer) and also the live docs and examples
@@ -34,7 +33,6 @@ For `npm run test`, we support these command line options:
 Command | Default | Description
 --------------------|----------- | -----------
  -c, --config | | Path to configuration json.
- -r, --renderer | model-viewer | The renderer to fidelity test, must be a web-based renderer.
  -s, --scenario | | Limit to specific scenarios. This now also allows you to specify multiple scenarios in the whitelist. You can use a full name or a partial name of scenarios and it will match against all that contain that scenario substring.
  -p, --port | 9040 | Port for web server.
  -d, --dry-run | false | Lists which images would be rendered but doesn't render. Useful when trying to figure out which tests will run given that command line.
@@ -57,7 +55,6 @@ For `npm run render-goldens`, we support these command line options:
 Command | Default | Description
 --------------------|----------- | -----------
  -c, --config | | Path to configuration json.
- -r, --renderer | | Limit to specific renderers. This now allows you to specify multiple renderers in the whitelist, rather than only one.
  -s, --scenario | | Limit to specific scenarios. This now also allows you to specify multiple scenarios in the whitelist. You can use a full name or a partial name of scenarios and it will match against all that contain that scenario substring.
  -p, --port | 9040 | Port for web server.
  -m, --missing-only | false | Only render if an output image is missing. Very useful when adding new tests.
@@ -67,7 +64,7 @@ Command | Default | Description
 To run a subset of renders or scenarios do something like this:
 
 ```
-% npm run render-goldens -- --renderer=filament --renderer=model-viewer --scenario=clearcoat -q 
+% npm run render-goldens -- --scenario=clearcoat -q 
 ```
 
 *NOTE: In the above example, the `--` is required to separate the arguments to `npm run render-goldens` from the arguments to the script itself.*

packages/render-fidelity-tools/package.json

@@ -23,10 +23,7 @@
  },
  "dependencies": {
  "@actions/core": "^1.2.4",
- "@babylonjs/core": "^6.25.0",
- "@babylonjs/loaders": "^6.25.0",
  "@google/model-viewer": "^3.5.0",
- "@khronosgroup/gltf-viewer": "^1.0.9",
  "@polymer/paper-button": "^3.0.1",
  "@polymer/paper-radio-group": "^3.0.1",
  "@polymer/paper-slider": "^3.0.1",
@@ -35,17 +32,12 @@
  "@types/pngjs": "^3.4.0",
  "@types/puppeteer": "^5.4.6",
  "@types/rimraf": "^3.0.1",
- "@types/three": "^0.163.0",
- "filament": "1.44.0",
  "http-server": "^14.1.1",
  "lit": "^2.7.2",
  "mkdirp": "^1.0.4",
  "pngjs": "^6.0.0",
  "puppeteer": "^21.3.4",
  "rimraf": "^3.0.2",
- "three": "^0.163.0",
- "three-gpu-pathtracer": "^0.0.20",
- "three-mesh-bvh": "^0.7.3",
  "yargs": "^17.7.2"
  },
  "devDependencies": {

packages/render-fidelity-tools/rollup.config.js

@@ -58,13 +58,6 @@ const buildTarget = (input, outputFormat) => ({
 const outputOptions = [
  buildTarget('./lib/components/image-comparison-app.js', 'esm'),
  buildTarget('./lib/components/renderer-harness.js', 'esm'),
- buildTarget('./lib/components/renderers/filament-viewer.js', 'esm'),
- buildTarget('./lib/components/renderers/babylon-viewer.js', 'esm'),
- // disabled until resolved: https://github.com/google/model-viewer/pull/3513
- // buildTarget('./lib/components/renderers/rhodonite-viewer.js', 'esm'),
- // buildTarget('./lib/components/renderers/dspbr-pt-viewer.js', 'esm'),
- buildTarget('./lib/components/renderers/gltf-sample-viewer.js', 'esm'),
- buildTarget('./lib/components/renderers/three-gpu-pathtracer-viewer.js', 'esm'),
  buildTarget('./lib/image-comparison-worker.js', 'iife')
 ];