Try to remove non-nullable converter if duplicate found for nullable targetType #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #1339
Solution description
When
targetType
is nullable and the class is annotated with both converters for nullable and non-nullable type,_compatibleMatch
returns two of them. So I've added a check iftargetType
is nullable andmatchingAnnotations
length is equal to 2, if so I proceed to try to find a non-null converter and remove it from the list ofmatchedConverters
.To Do