Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compilation errors with interleaved_test.cc on x86 #2178

Merged
merged 1 commit into from
May 17, 2024
Merged

Fixed compilation errors with interleaved_test.cc on x86 #2178

merged 1 commit into from
May 17, 2024

Conversation

johnplatts
Copy link
Contributor

Fixed compilation errors with interleaved_test.cc on x86 if AVX3 targets are enabled.

@johnplatts johnplatts mentioned this pull request May 16, 2024
Merged
jan-wassenberg
jan-wassenberg approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing :) That's a better way.
BTW I have on my TODO to gate our CLs on certain Github actions, which would have caught this.

@copybara-service copybara-service bot merged commit a8ac314 into google:master May 17, 2024
7 of 33 checks passed
johnplatts added a commit to johnplatts/jep_google_highway that referenced this pull request May 22, 2024
@johnplatts
Squashed commit of the following:
17da0af 
commit 7fcd901
Merge: 9402abc 7feda2e
Author: Copybara-Service <[email protected]>
Date:   Wed May 22 08:21:13 2024 -0700

    Merge pull request google#2192 from google:dependabot/github_actions/step-security/harden-runner-2.8.0

    PiperOrigin-RevId: 636173991

commit 9402abc
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 22 06:56:16 2024 -0700

    Re-enable float to int test; UB is fixed in google#2189

    Also enable for f16/bf16 and account for their lower precision.

    PiperOrigin-RevId: 636151546

commit 7feda2e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed May 22 13:34:20 2024 +0000

    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 5c5861d
Merge: b76a3f4 7a38a3b
Author: Copybara-Service <[email protected]>
Date:   Wed May 22 05:47:31 2024 -0700

    Merge pull request google#2189 from johnplatts:hwy_gcc12_x86_f2i_fix_052024

    PiperOrigin-RevId: 636134820

commit b76a3f4
Author: Pawan Dogra <[email protected]>
Date:   Wed May 22 02:36:13 2024 -0700

    Add frame of reference to Pack32/Pack64

    PiperOrigin-RevId: 636091655

commit 2270e77
Merge: 4ff7725 6d188e8
Author: Copybara-Service <[email protected]>
Date:   Tue May 21 07:43:52 2024 -0700

    Merge pull request google#2191 from google:dependabot/github_actions/github/codeql-action-3.25.6

    PiperOrigin-RevId: 635803410

commit 6d188e8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 21 13:44:22 2024 +0000

    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 7a38a3b
Author: John Platts <[email protected]>
Date:   Mon May 20 17:17:19 2024 -0500

    Workaround for UB in x86 ConvertInRangeTo with GCC

commit 4ff7725
Author: Jan Wassenberg <[email protected]>
Date:   Tue May 21 00:57:52 2024 -0700

    simplify interleaved_test, fixes GCC AVX2/3

    PiperOrigin-RevId: 635710576

commit 468b2af
Author: Highway <[email protected]>
Date:   Fri May 17 10:22:33 2024 -0700

    re-enable vqsort for sanitizers on arm

    PiperOrigin-RevId: 634816994

commit 0403957
Author: Jan Wassenberg <[email protected]>
Date:   Fri May 17 08:37:54 2024 -0700

    fix GCC warnings (cast after arithmetic, but not for Iota)

    PiperOrigin-RevId: 634787566

commit 9dc6e1e
Author: Jan Wassenberg <[email protected]>
Date:   Fri May 17 07:11:12 2024 -0700

    avoid GCC "UB" in truncating cases. Fixes google#2183

    PiperOrigin-RevId: 634761043

commit 0c0f61a
Author: Jan Wassenberg <[email protected]>
Date:   Fri May 17 06:10:20 2024 -0700

    internal test infra

    PiperOrigin-RevId: 634735656

commit a8ac314
Merge: b4bb7b4 b476308
Author: Copybara-Service <[email protected]>
Date:   Fri May 17 05:18:20 2024 -0700

    Merge pull request google#2178 from johnplatts:hwy_interleaved_test_fix_051524

    PiperOrigin-RevId: 634722749

commit b4bb7b4
Author: Jan Wassenberg <[email protected]>
Date:   Thu May 16 07:34:35 2024 -0700

    Clang RVV fixes:

    Bug in ReorderDemoteTo implementation (wrong lane type)
    MatVecAdd: simpler code, avoid duplicate test, to avoid timeout
    arithmetic: incorrect codegen for EMU128, avoid vector passing to non-inlined func
    PiperOrigin-RevId: 634385763

commit 3d61828
Merge: 8295336 967dc1d
Author: Copybara-Service <[email protected]>
Date:   Thu May 16 07:12:15 2024 -0700

    Merge pull request google#2180 from johnplatts:hwy_cmake_cxx17_051624

    PiperOrigin-RevId: 634377290

commit 967dc1d
Author: John Platts <[email protected]>
Date:   Thu May 16 08:12:51 2024 -0500

    Updated CMakeLists.txt to compile in C++17 mode by default

commit 8295336
Merge: b7cff55 843b834
Author: Copybara-Service <[email protected]>
Date:   Thu May 16 03:38:13 2024 -0700

    Merge pull request google#2177 from johnplatts:hwy_cxx11_dispatch_fix_051524

    PiperOrigin-RevId: 634293551

commit b7cff55
Merge: fdf3bde 42cb392
Author: Copybara-Service <[email protected]>
Date:   Thu May 16 01:49:13 2024 -0700

    Merge pull request google#2176 from johnplatts:hwy_targets_test_fix_051524

    PiperOrigin-RevId: 634264735

commit fdf3bde
Author: Jan Wassenberg <[email protected]>
Date:   Thu May 16 01:46:53 2024 -0700

    add 1.2 changelog, clarify ReorderWidenMulAccumulate doc

    PiperOrigin-RevId: 634264368

commit 843b834
Author: John Platts <[email protected]>
Date:   Wed May 15 11:34:46 2024 -0500

    Made fixes to C++11/C++14 HWY_EXPORT_T

commit b476308
Author: John Platts <[email protected]>
Date:   Wed May 15 13:16:04 2024 -0500

    Fixed compilation errors with HwyInterleavedTest on x86

commit 42cb392
Author: John Platts <[email protected]>
Date:   Wed May 15 11:17:08 2024 -0500

    Made UB fixes in targets_test if HWY_SCALAR is enabled

commit 0ff3341
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 08:53:05 2024 -0700

    fix GCC unused arg, RVV macro \, enable opt-in to NEON_BF16

    PiperOrigin-RevId: 633970610

commit 8be1307
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 07:48:30 2024 -0700

    Fix/improve RVV bf16 convert

    Use the native vxrm RNE rounding mode where supported.
    GCC 13 defaults to RNU, which rounds 7F7F[8..0] to 7F80.
    Note that QEMU also has an issue, see
    https://www.mail-archive.com/[email protected]/msg309080.html

    Also add new test cases.

    PiperOrigin-RevId: 633952516

commit a3e3f70
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 05:02:01 2024 -0700

    fix RVV Dup128MaskFromMaskBits (incorrect bits)

    PiperOrigin-RevId: 633905415

commit 68f9f48
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 02:40:41 2024 -0700

    RVV Hypot fix: inf,nan => inf, non-constexpr inputs

    PiperOrigin-RevId: 633868137

commit 8700d5d
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 01:02:46 2024 -0700

    Fix PPC BlendedStore, add RESTRICT to CopyBytes

    Also remove CPU flags from PPC tests because dynamic dispatch is now supported

    PiperOrigin-RevId: 633846096

commit d1cacc2
Author: Jan Wassenberg <[email protected]>
Date:   Wed May 15 00:29:46 2024 -0700

    fix for NEON_BF16: new clang's incompatible fullfp16

    PiperOrigin-RevId: 633838960

commit 2cd58f3
Merge: e3e191a 24f50c6
Author: Copybara-Service <[email protected]>
Date:   Tue May 14 08:05:53 2024 -0700

    Merge pull request google#2166 from johnplatts:hwy_z14_extractm_051314

    PiperOrigin-RevId: 633587401

commit e3e191a
Merge: 345e4c4 1603618
Author: Copybara-Service <[email protected]>
Date:   Tue May 14 07:30:42 2024 -0700

    Merge pull request google#2168 from johnplatts:hwy_map_dispatch_fix_051424

    PiperOrigin-RevId: 633578542

commit 345e4c4
Author: Paul Chang <[email protected]>
Date:   Tue May 14 07:06:25 2024 -0700

    Fix compile errors in MulEvenAdd/MulOddAdd

    PiperOrigin-RevId: 633573013

commit 1603618
Author: John Platts <[email protected]>
Date:   Tue May 14 09:03:30 2024 -0500

    Fix compilation errors if HWY_DISPATCH_MAP is 1

commit 24f50c6
Author: John Platts <[email protected]>
Date:   Mon May 13 19:51:11 2024 -0500

    Updated detail::ExtractSignBits on Z14/Z15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-wassenberg jan-wassenberg jan-wassenberg approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnplatts @jan-wassenberg