Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Change enterprise runner to also use ListRunnersOptions #3167

Merged
merged 1 commit into from
May 13, 2024

Conversation

ponkio-o
Copy link
Contributor

@ponkio-o ponkio-o commented May 13, 2024

Fixes: #3166.

BREAKING-CHANGE: This changes ListOptions to ListRunnersOptions in EnterpriseService.ListRunners.

I fixed a bug related ListRunners API. The ListRunnersOptions was not being applied to Enterprise Runner.
follow up: #3094

Copy link

google-cla bot commented May 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title fix: changed enterprise runner to also use ListRunnersOptions feat!: Change enterprise runner to also use ListRunnersOptions May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (2b8c7fa) to head (00ae280).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3167      +/-   ##
==========================================
- Coverage   97.72%   92.91%   -4.81%     
==========================================
  Files         153      171      +18     
  Lines       13390    11502    -1888     
==========================================
- Hits        13085    10687    -2398     
- Misses        215      724     +509     
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). waiting for signed CLA labels May 13, 2024
@ponkio-o
Copy link
Contributor Author

@gmlewis Sorry, I just completed signing the CLA.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ponkio-o !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented May 13, 2024

@fentas - perhaps you are available to review this?

Copy link
Contributor

@fentas fentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 13, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented May 13, 2024

Thank you, @fentas ! Merging.

@gmlewis gmlewis merged commit 4169a9c into google:master May 13, 2024
6 of 7 checks passed
@ponkio-o ponkio-o deleted the fix/consider-ent-runner branch May 13, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListRunnersOption change omits consideration of Enterprise Runner
3 participants