Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for check private vulnerability reporting endpoint #3157

Merged
merged 10 commits into from May 5, 2024

Conversation

Sairaviteja27
Copy link
Contributor

fixes #3152

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (6e51ef7).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   97.72%   92.89%   -4.84%     
==========================================
  Files         153      170      +17     
  Lines       13390    11466    -1924     
==========================================
- Hits        13085    10651    -2434     
- Misses        215      724     +509     
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !

github/repos.go Outdated
Comment on lines 2406 to 2407
// CheckPrivateReporting represents whether private vulnerability reporting is enabled.
type CheckPrivateReporting struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be private since it isn't exposed anywhere to the end-user.

github/repos.go Outdated Show resolved Hide resolved
@Sairaviteja27 Sairaviteja27 marked this pull request as draft May 3, 2024 17:36
github/repos.go Outdated Show resolved Hide resolved
Co-authored-by: Glenn Lewis <[email protected]>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 3, 2024
@Sairaviteja27 Sairaviteja27 marked this pull request as ready for review May 3, 2024 17:55
@Sairaviteja27
Copy link
Contributor Author

@gmlewis I think code coverage check is failing. Could you suggest if I should I add tests in other methods?

@gmlewis
Copy link
Collaborator

gmlewis commented May 3, 2024

@gmlewis I think code coverage check is failing. Could you suggest if I should I add tests in other methods?

Don't worry about that. We've had some weirdness with codecov lately and I've made two reports with the problems we've seen and don't have any resolution yet. Thanks, though.

@gmlewis
Copy link
Collaborator

gmlewis commented May 5, 2024

Thank you, @be0x74a !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
@gmlewis gmlewis merged commit 5868a66 into google:master May 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new REST API endpoint that evaluates if private vulnerability reporting is enabled
3 participants