Fix comment NOTE about SetVLOGLevel #1109
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 63.57% 64.08% +0.50%
==========================================
Files 20 20
Lines 2578 2578
Branches 894 906 +12
==========================================
+ Hits 1639 1652 +13
+ Misses 671 662 -9
+ Partials 268 264 -4 |
I have put a basic description of |
sergiud
requested changes
Jun 25, 2024
| There's also `#!cpp VLOG_IS_ON(n)` "verbose level" condition macro. This macro | ||
| returns `#!cpp true` when the `--v` is equal to or greater than `n`. The macro can be | ||
| used as follows: | ||
| returns `#!cpp true` when the matching `--vmodule`, else `--v` is equal to or greater than `n`. |
There was a problem hiding this comment.
This description seems to be broken now. The else part looks out of place. What am I missing?
There was a problem hiding this comment.
I was trying to convey the fact that if there is no matching --vmodule then --v is used. Should we just change it to "when the level is equal to or greater than"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the comment about
SetVLOGLevelaccording to #650 which added support for updating vmodule levels after vmodule level has been cached.Fixes #858