Register all log files with cleaner #1086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures logs at other verbosity levels are cleaned up even if they are not logged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 60.52% 60.72% +0.19%
==========================================
Files 19 19
Lines 2574 2607 +33
Branches 917 933 +16
==========================================
+ Hits 1558 1583 +25
- Misses 676 687 +11
+ Partials 340 337 -3
|
|
This implements the suggested registration approach. Any comments? |
|
Thanks for submitting the revised PR! Unfortunately, I need some time to review the changes in detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures logs at other verbosity levels are cleaned up even if they are not logged