Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment describing SetVLOGLevel is not accurate #858

Open
hari90 opened this issue Sep 7, 2022 · 2 comments · May be fixed by #1109
Open

Comment describing SetVLOGLevel is not accurate #858

hari90 opened this issue Sep 7, 2022 · 2 comments · May be fixed by #1109
Labels
PR welcome

Comments

@hari90
Copy link

hari90 commented Sep 7, 2022 •
edited by sergiud
Loading

Currently the comment states the following:

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that have already executed after/during InitGoogleLogging,
//	 one needs to supply the exact --vmodule pattern that applied to them.
//       (If no --vmodule pattern applied to them
//       the value of FLAGS_v will continue to control them.)

But #650 added support for updating vmodule levels after vmodule level has been cached.

The comment should be

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that matched a prior --vmodule pattern then the exact pattern has to be supplied again.
//       (If no --vmodule pattern applied to them before then the first matching pattern will start to control them.)
@sergiud
Copy link
Collaborator

sergiud commented Jan 5, 2024

@romange Could you please verify the suggestion?

@hari90 hari90 linked a pull request Jun 21, 2024 that will close this issue
Open
@hari90
Copy link
Author

hari90 commented Jun 22, 2024

@sergiud @romange I submitted #1109 for this. Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comment NOTE about SetVLOGLevel hari90/glog
2 participants
@sergiud @hari90