Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Add netstandard2.0 as target #8295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjornharrtell
Copy link
Collaborator

ref #8293

@bjornharrtell
Copy link
Collaborator Author

@ccorsano would you be willing to try this out in your scenario with .NET Source Generators?

@ccorsano
Copy link

@bjornharrtell I got your changes and was able to integrate the library with my source generator test project, it looks good to me.

My little experiment then fell short as my idea required file IO (to generate a bfbs schema then parse it), which, as I now learned is heavily discouraged (to not say forbidden) in source generators.

That being said, the alternative way of achieving my current goal is to write a custom MSBuild task, which has the same constraint of requiring netstandard2.0 (due to Visual Studio still running .Net Framework internally).

Overall netstandard2.0 is the last bridge to .Net Framework, so I still think it is a valuable target to keep.

@bjornharrtell
Copy link
Collaborator Author

Hmm.. a bridge to .NET Framework is something else which I'm not to keen on myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants