Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the code generated for enum types to avoid conflicting with names not reserved by the Flatbuffers IDL #8285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust the code generated for enum types to avoid conflicting with names not reserved by the Flatbuffers IDL #8285

wants to merge 1 commit into from

Commits on Apr 19, 2024

  1. Adjust the code generated for enum types to avoid conflicting with na… 

    …mes not reserved by the Flatbuffers IDL

Fixes google#8052

The Flatbuffers IDL allows for enums to have values called "value", "values", "minValue" or "maxValue", but if these names are used for values in an enum, the generated Dart code won't compile.

This modifies the Dart generator to use "$value", "$values", "$minValue" and "$maxValue" instead, so that valid Flatbuffer schemas can be used wth Dart
    @insertjokehere
    insertjokehere committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1b39351 View commit details
    Browse the repository at this point in the history